Index: [thread] [date] [author] [stats]
  From: markus schnalke <meillo@marmaro.de>
  To  : <masqmail@marmaro.de>
  Date: Wed, 14 Jul 2010 12:35:31 +0200

Re: [masqmail] Documentation and build system improvements

[2010-07-14 11:06] "Nico R." <n-roeser@gmx.net>
> 
> I have made a few local changes to the Masqmail documentation. In
> addition to that, I have also improved the configure script with regards
> to the ‘--without-liblockfile’ option.

Thanks for your work.


> I’m attaching a Mercurial changegroup file and also a diff file in case
> you like that better (though it lacks the commit messages). :-)

I like simple diffs more. I anyways want to have a look at the stuff.
Additionally, a diff is plain text and anyone can read it and apply it
manually if wished. Mercurial's bundle stuff appears to be a bit
strange:

    $ file masqmail-cd38f10532e7.bundle
    masqmail-cd38f10532e7.bundle: Mercurial changeset bundle (bzip2 compressed)
    
    $ bunzip2 <masqmail-cd38f10532e7.bundle
    bunzip2: (stdin) is not a bzip2 file.

To add the commit messages, you could add the relevant segment of `hg
log -v' or supply the diffs as generated by `hg export REV'.


> I’d be happy if you could review the changes made by me and tell me what
> you think about them.

I applied the configure stuff without change and untested. You
probably know autoconf good enough that you know what you do. At least
you know it much better than I do.

I applied almost all of your documentation improvements without
change.

This change I didn't apply:

    -To compile masqmail you need glib (>= 1.2) (http://www.gtk.org). Yo2biHHH‘ur
    +To compile masqmail you need GLib 2 (http://www.gtk.org). Your

AFAIK masqmail can still use glib-1.2. If not, please tell me.


Thanks for the patch.


meillo


Index: [thread] [date] [author] [stats]